hyperswitch icon indicating copy to clipboard operation
hyperswitch copied to clipboard

fix(ci): abrupt exit upon ci failure

Open pixincreate opened this issue 1 year ago • 2 comments

Type of Change

  • [x] Bugfix
  • [ ] New feature
  • [ ] Enhancement
  • [ ] Refactoring
  • [ ] Dependency updates
  • [ ] Documentation
  • [ ] CI/CD

Description

When CI checks are run in parallel, it would result in abrupt exit when one of the connector failed. This PR aims to fix that.

closes #6890

Additional Changes

  • [ ] This PR modifies the API contract
  • [ ] This PR modifies the database schema
  • [ ] This PR modifies application configuration/environment variables

Motivation and Context

Parallel CI needed this fix for so long.

How did you test it?

This cannot be tested without running CI checks in parallel which is bound to fail due to resource constraints.

The issue cannot be reproduced in local at all.

This change shouldn't cause any abrupt exits going forward.

Checklist

  • [ ] I formatted the code cargo +nightly fmt --all
  • [ ] I addressed lints thrown by cargo clippy
  • [x] I reviewed the submitted code
  • [ ] I added unit tests for my changes where possible

pixincreate avatar Dec 19 '24 09:12 pixincreate

Review changes with  SemanticDiff

semanticdiff-com[bot] avatar Dec 19 '24 09:12 semanticdiff-com[bot]

this is not a priority. i'll mark it as draft for now until root cause of abrupt fail is detected.

pixincreate avatar Dec 20 '24 07:12 pixincreate