hyperswitch icon indicating copy to clipboard operation
hyperswitch copied to clipboard

refactor(router): add amount conversion framework to netcetera

Open hex1c opened this issue 1 year ago • 9 comments

Type of Change

  • [ ] Bugfix
  • [ ] New feature
  • [ ] Enhancement
  • [x] Refactoring
  • [ ] Dependency updates
  • [ ] Documentation
  • [ ] CI/CD

Description

Minor refactoring to standardize Netcetera connector to use the conversion framework to reduce potential inconsistencies in managing amounts fixes #5930

Checklist

  • [x] I formatted the code cargo +nightly fmt --all
  • [x] I addressed lints thrown by cargo clippy
  • [x] I reviewed the submitted code
  • [ ] I added unit tests for my changes where possible

hex1c avatar Oct 05 '24 06:10 hex1c

Please run cargo +nightly fmt --all once and commit.

hrithikesh026 avatar Oct 15 '24 07:10 hrithikesh026

@hrithikesh026 review comments done!

hex1c avatar Oct 15 '24 12:10 hex1c

@hex1c Please run the following command to fix the formatting of this pr

cargo +nightly fmt

deepanshu-iiitu avatar Oct 17 '24 06:10 deepanshu-iiitu

@deepanshu-iiitu sorry missed the formatting after the last refactor. Formatted the code now :)

hex1c avatar Oct 17 '24 15:10 hex1c

@hrithikesh026 there was a compilation issue fixed it now

hex1c avatar Oct 22 '24 12:10 hex1c

Hey @hex1c Can you work on the above suggested changes

deepanshu-iiitu avatar Oct 24 '24 11:10 deepanshu-iiitu

Hey @hex1c Kindly look into the comments, and make the changes!

gorakhnathy7 avatar Nov 05 '24 06:11 gorakhnathy7

@deepanshu-iiitu made the changes kindly review it and let me know if there are any changes.

hex1c avatar Nov 10 '24 06:11 hex1c