hyperswitch icon indicating copy to clipboard operation
hyperswitch copied to clipboard

refactor(router): add amount conversion framework to nexinets

Open hex1c opened this issue 1 year ago • 4 comments

Type of Change

  • [ ] Bugfix
  • [ ] New feature
  • [ ] Enhancement
  • [x] Refactoring
  • [ ] Dependency updates
  • [ ] Documentation
  • [ ] CI/CD

Description

Minor refactoring to standardizeNexinets connector to use the conversion framework to reduce potential inconsistencies in managing amounts fixes #6095 .

Additional Changes

  • [ ] This PR modifies the API contract
  • [ ] This PR modifies the database schema
  • [ ] This PR modifies application configuration/environment variables

Checklist

  • [x] I formatted the code cargo +nightly fmt --all
  • [x] I addressed lints thrown by cargo clippy
  • [x] I reviewed the submitted code
  • [ ] I added unit tests for my changes where possible

hex1c avatar Oct 02 '24 18:10 hex1c

@awasthi21 review changes done

hex1c avatar Oct 14 '24 13:10 hex1c

@hex1c Please resolve the conflicts

deepanshu-iiitu avatar Oct 24 '24 11:10 deepanshu-iiitu

Hey @hex1c Can you please look into the comments, and make the changes!

gorakhnathy7 avatar Nov 05 '24 06:11 gorakhnathy7