hyperswitch icon indicating copy to clipboard operation
hyperswitch copied to clipboard

refactor(connector): add amount conversion framework to payu

Open rahulpatwal0922 opened this issue 1 year ago • 1 comments

Type of Change

  • [ ] Bugfix
  • [ ] New feature
  • [ ] Enhancement
  • [x] Refactoring
  • [ ] Dependency updates
  • [ ] Documentation
  • [ ] CI/CD

Description

This PR adds amount conversion framework to payu, for sending to connector

Additional Changes

  • [ ] This PR modifies the API contract
  • [ ] This PR modifies the database schema
  • [ ] This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Checklist

  • [x] I formatted the code cargo +nightly fmt --all
  • [x] I addressed lints thrown by cargo clippy
  • [x] I reviewed the submitted code
  • [ ] I added unit tests for my changes where possible

rahulpatwal0922 avatar Oct 02 '24 14:10 rahulpatwal0922

Review changes with SemanticDiff.

Analyzed 4 of 4 files.

Overall, the semantic diff is 29% smaller than the GitHub diff.

Filename Status
:heavy_check_mark: crates/router/tests/connectors/payu.rs 51.88% smaller
:heavy_check_mark: crates/router/src/types/api.rs 79.34% smaller
:heavy_check_mark: crates/hyperswitch_connectors/src/connectors/payu.rs 22.88% smaller
:heavy_check_mark: crates/hyperswitch_connectors/src/connectors/payu/transformers.rs 33.9% smaller

semanticdiff-com[bot] avatar Oct 02 '24 14:10 semanticdiff-com[bot]

Hey @rahulpatwal0922 Kindly look into the changes

gorakhnathy7 avatar Oct 08 '24 08:10 gorakhnathy7

Sure @gorakhnathy7 I Will make the requested changes.

rahulpatwal0922 avatar Oct 08 '24 10:10 rahulpatwal0922

@gorakhnathy7 @Sakilmostak changes done.

rahulpatwal0922 avatar Oct 08 '24 17:10 rahulpatwal0922

@gorakhnathy7 @Sakilmostak changes done.

hey @rahulpatwal0922 can you push one empty commit, we want to run the remaining checks before merging this.

mrudulvajpayee4935 avatar Oct 15 '24 05:10 mrudulvajpayee4935

@rahulpatwal0922 Can you resolve the conflicts

Gnanasundari24 avatar Oct 24 '24 11:10 Gnanasundari24

@rahulpatwal0922 Can you resolve the conflicts

sure

rahulpatwal0922 avatar Oct 24 '24 11:10 rahulpatwal0922