hyperswitch icon indicating copy to clipboard operation
hyperswitch copied to clipboard

[REFACTOR]: [RISKIFIED] Add amount conversion framework to Riskified

Open ImSagnik007 opened this issue 1 year ago • 4 comments

:memo: Feature Description

Currently, amounts are represented as i64 values throughout the application. We want to introduce a Unit struct that explicitly states the denomination. A new type, MinorUnit, has been added to standardize the flow of amounts across the application. This type will now be used by all the connector flows.

Rather than handling conversions in each connector, we will centralize the conversion logic in one place within the core of the application.

:hammer: Possible Implementation

  • For each connector, we need to create an amount conversion function. Connectors will specify the format they require, and the core framework will handle the conversion accordingly.
  • Connectors should invoke the convert function to receive the amount in their required format.
  • Refer to the connector documentation to determine the required amount format for each connector.
  • You can refer this PR for more context.

🔖 Note: All the changes needed should be contained within hyperswitch/crates/router/src/connector/ , crates/router/src/types/api.rs , crates/router/tests/connectors/

:package: Have you spent some time checking if this feature request has been raised before?

  • [ ] I checked and didn't find a similar issue

:package: Have you read the Contributing Guidelines?

:sparkles: Are you willing to submit a PR?

Submission Process:

  • Ask the maintainers for assignment of the issue, you can request for assignment by commenting on the issue itself.
  • Once assigned, submit a pull request (PR).
  • Maintainers will review and provide feedback, if any.
  • Maintainers can unassign issues due to inactivity, read more here.

Refer here for Terms and conditions for the contest.

ImSagnik007 avatar Sep 26 '24 19:09 ImSagnik007

I am interested

tanbirali avatar Sep 27 '24 18:09 tanbirali

Hi @ImSagnik007 , I would like to work on this issue. Please assign it to me.

Ankesh2004 avatar Oct 01 '24 13:10 Ankesh2004

Hello! Could you assign this to me? @ImSagnik007

IshuSinghSE avatar Oct 03 '24 17:10 IshuSinghSE

Hey All, assigning this issue to @IshuSinghSE to maintain fairness, As rest of the folks are already working on other issues.

gorakhnathy7 avatar Oct 03 '24 17:10 gorakhnathy7

Hey @gorakhnathy7 , as there is no current assignee , Could you assign this to me?

Sidharth-Singh10 avatar Oct 06 '24 16:10 Sidharth-Singh10

Hey @Sidharth-Singh10 Can you please pick any other issue from here.

gorakhnathy7 avatar Oct 07 '24 09:10 gorakhnathy7

@gorakhnathy7, can I pick up this issue? as there is no current assignee.

Sidharth-Singh10 avatar Oct 16 '24 08:10 Sidharth-Singh10

Sure @Sidharth-Singh10 Assigning this to you, Thanks for your interest.

gorakhnathy7 avatar Oct 16 '24 22:10 gorakhnathy7