hyperswitch icon indicating copy to clipboard operation
hyperswitch copied to clipboard

[REFACTOR]: [ZEN] Add amount conversion framework to Zen

Open ImSagnik007 opened this issue 1 year ago • 2 comments

:memo: Feature Description

Currently, amounts are represented as i64 values throughout the application. We want to introduce a Unit struct that explicitly states the denomination. A new type, MinorUnit, has been added to standardize the flow of amounts across the application. This type will now be used by all the connector flows.

Rather than handling conversions in each connector, we will centralize the conversion logic in one place within the core of the application.

:hammer: Possible Implementation

  • For each connector, we need to create an amount conversion function. Connectors will specify the format they require, and the core framework will handle the conversion accordingly.
  • Connectors should invoke the convert function to receive the amount in their required format.
  • Refer to the connector documentation to determine the required amount format for each connector.
  • You can refer this PR for more context.

🔖 Note: All the changes needed should be contained within hyperswitch/crates/router/src/connector/ , crates/router/src/types/api.rs , crates/router/tests/connectors/

:package: Have you spent some time checking if this feature request has been raised before?

  • [ ] I checked and didn't find a similar issue

:package: Have you read the Contributing Guidelines?

:sparkles: Are you willing to submit a PR?

Submission Process:

  • Ask the maintainers for assignment of the issue, you can request for assignment by commenting on the issue itself.
  • Once assigned, submit a pull request (PR).
  • Maintainers will review and provide feedback, if any.
  • Maintainers can unassign issues due to inactivity, read more here.

Refer here for Terms and conditions for the contest.

ImSagnik007 avatar Sep 26 '24 19:09 ImSagnik007

Hey @ImSagnik007 , I would like to work on this connector issue

ayan-joshi avatar Sep 27 '24 12:09 ayan-joshi

Please assign me this issue as I would love to work on this issue.

SanchitMahajan236 avatar Oct 02 '24 21:10 SanchitMahajan236

Hey @ayan-joshi i see you are already working on another issue, thus assigning this to @SanchitMahajan236

gorakhnathy7 avatar Oct 03 '24 05:10 gorakhnathy7

Hey @SanchitMahajan236 ,

Quick check-in on the status of this issue. If you have any questions or need assistance, feel free to reach out in the community.

gorakhnathy7 avatar Oct 06 '24 06:10 gorakhnathy7

Hi @gorakhnathy7 , I am currently working on the issue.

SanchitMahajan236 avatar Oct 06 '24 11:10 SanchitMahajan236

Hi @SanchitMahajan236 , Are you still working on this issue? Please let us know if you need any help

swangi-kumari avatar Oct 18 '24 11:10 swangi-kumari

Hi @swangi-kumari if the issue is up for grabs, please assign it to me.I would like to work on it.

hex1c avatar Oct 18 '24 18:10 hex1c

Hi @swangi-kumari , I'm still working on the issue.

SanchitMahajan236 avatar Oct 19 '24 06:10 SanchitMahajan236