hyperswitch icon indicating copy to clipboard operation
hyperswitch copied to clipboard

[REFACTOR]: [MOLLIE] Add amount conversion framework to Mollie

Open swangi-kumari opened this issue 1 year ago • 4 comments

:memo: Feature Description

Currently, amounts are represented as i64 values throughout the application. We want to introduce a Unit struct that explicitly states the denomination. A new type, MinorUnit, has been added to standardize the flow of amounts across the application. This type will now be used by all the connector flows.

Rather than handling conversions in each connector, we will centralize the conversion logic in one place within the core of the application.

:hammer: Possible Implementation

  • For each connector, we need to create an amount conversion function. Connectors will specify the format they require, and the core framework will handle the conversion accordingly.
  • Connectors should invoke the convert function to receive the amount in their required format.
  • Refer to the connector documentation to determine the required amount format for each connector.
  • You can refer this PR for more context.

🔖 Note: All the changes needed should be contained within hyperswitch/crates/router/src/connector/ , crates/router/src/types/api.rs , crates/router/tests/connectors/

:package: Have you spent some time checking if this feature request has been raised before?

  • [ ] I checked and didn't find a similar issue

:package: Have you read the Contributing Guidelines?

:package: Submission Process:

  • Ask the maintainers for assignment of the issue, you can request for assignment by commenting on the issue itself.
  • Once assigned, submit a pull request (PR).
  • Maintainers will review and provide feedback, if any.
  • Maintainers can unassign issues due to inactivity, read more here.

Refer here for Terms and conditions for the contest.

:sparkles: Are you willing to submit a PR?

swangi-kumari avatar Sep 26 '24 07:09 swangi-kumari

Hey @swangi-kumari , please assign me this issue

sahil9001 avatar Oct 01 '24 03:10 sahil9001

Hey @sahil9001 Thanks for your interest, As you have requested another issue to you, i would suggest to keep working on it. Please reach out here, once that is done. This will help us maintain fairness in the assignment process.

gorakhnathy7 avatar Oct 02 '24 10:10 gorakhnathy7

Hey @swangi-kumari I would like to work on this issue.

aayushdhiman01 avatar Oct 03 '24 13:10 aayushdhiman01

Sure @aayushdhiman01 , I have assigned this issue to you. In case you have any queries, you can ask them on this issue thread, or on our discord server

swangi-kumari avatar Oct 03 '24 13:10 swangi-kumari

Hey @aayushdhiman01 ,

Quick check-in on the status of this issue. If you have any questions or need assistance, feel free to reach out in the community.

gorakhnathy7 avatar Oct 06 '24 06:10 gorakhnathy7

Hey @gorakhnathy7 , I would like to work on this issue.

Sidharth-Singh10 avatar Oct 07 '24 10:10 Sidharth-Singh10

Sure @Sidharth-Singh10 assigning the issue to you!

gorakhnathy7 avatar Oct 08 '24 08:10 gorakhnathy7

Hey @Sidharth-Singh10

Thanks for participating! Kindly fill this form once all of your PRs are merged.

gorakhnathy7 avatar Oct 24 '24 07:10 gorakhnathy7

@gorakhnathy7 ,does the form have to contain PRs that are merged before 1Nov only?

Sidharth-Singh10 avatar Oct 28 '24 19:10 Sidharth-Singh10