hyperswitch icon indicating copy to clipboard operation
hyperswitch copied to clipboard

[REFACTOR]: [RAPYD] Add amount conversion framework to Rapyd

Open mrudulvajpayee4935 opened this issue 1 year ago • 2 comments

:memo: Feature Description

Currently, amounts are represented as i64 values throughout the application. We want to introduce a Unit struct that explicitly states the denomination. A new type, MinorUnit, has been added to standardize the flow of amounts across the application. This type will now be used by all the connector flows.

Rather than handling conversions in each connector, we will centralize the conversion logic in one place within the core of the application.

:hammer: Possible Implementation

  • For each connector, we need to create an amount conversion function. Connectors will specify the format they require, and the core framework will handle the conversion accordingly.
  • Connectors should invoke the convert function to receive the amount in their required format.
  • Refer to the connector documentation to determine the required amount format for each connector.
  • You can refer this PR for more context.

🔖 Note: All the changes needed should be contained within hyperswitch/crates/router/src/connector/ , crates/router/src/types/api.rs , crates/router/tests/connectors/

:package: Have you spent some time checking if this feature request has been raised before?

  • [X] I checked and didn't find a similar issue

:package: Have you read the Contributing Guidelines?

:package: Submission Process:

  • Ask the maintainers for assignment of the issue, you can request for assignment by commenting on the issue itself.
  • Once assigned, submit a pull request (PR).
  • Maintainers will review and provide feedback, if any.
  • Maintainers can unassign issues due to inactivity, read more here.

Refer here for Terms and conditions for the contest.

:sparkles: Are you willing to submit a PR?

mrudulvajpayee4935 avatar Sep 25 '24 07:09 mrudulvajpayee4935

Hi @mrudulvajpayee4935, I'd like to work on this issue. Can you please assign this to me?

ankkyprasad avatar Oct 01 '24 12:10 ankkyprasad

@ankkyprasad Assigning this to you!

gorakhnathy7 avatar Oct 02 '24 15:10 gorakhnathy7

Hey @ankkyprasad ,

Quick check-in on the status of this issue. If you have any questions or need assistance, feel free to reach out in the community.

gorakhnathy7 avatar Oct 06 '24 06:10 gorakhnathy7

Hi,

I would like to contribute to this issue if there is no update.

qstommyshu avatar Oct 15 '24 00:10 qstommyshu

Hey @qstommyshu You have already been assigned another issue, let me know if you want to work on this one instead.

gorakhnathy7 avatar Oct 15 '24 22:10 gorakhnathy7

I should be able to finish my other tickets within this week then I would be available for this one.

qstommyshu avatar Oct 15 '24 23:10 qstommyshu

hey @gorakhnathy7 as no one is assigned this issue currently, can you assign it to me?

gauravghodinde avatar Oct 19 '24 12:10 gauravghodinde

Sure @gauravghodinde

gorakhnathy7 avatar Oct 21 '24 01:10 gorakhnathy7

Hey @gauravghodinde Thanks for participating! Kindly fill this form once all of your PRs are merged.

gorakhnathy7 avatar Oct 31 '24 09:10 gorakhnathy7