hyperswitch icon indicating copy to clipboard operation
hyperswitch copied to clipboard

[REFACTOR]: [HELCIM] Add amount conversion framework to Helcim

Open ImSagnik007 opened this issue 1 year ago • 1 comments

:memo: Feature Description

Currently, amounts are represented as i64 values throughout the application. We want to introduce a Unit struct that explicitly states the denomination. A new type, MinorUnit, has been added to standardize the flow of amounts across the application. This type will now be used by all the connector flows.

Rather than handling conversions in each connector, we will centralize the conversion logic in one place within the core of the application.

:hammer: Possible Implementation

  • For each connector, we need to create an amount conversion function. Connectors will specify the format they require, and the core framework will handle the conversion accordingly.
  • Connectors should invoke the convert function to receive the amount in their required format.
  • Refer to the connector documentation to determine the required amount format for each connector.
  • You can refer this PR for more context.

🔖 Note: All the changes needed should be contained within hyperswitch/crates/router/src/connector/ , crates/router/src/types/api.rs , crates/router/tests/connectors/

:package: Have you spent some time checking if this feature request has been raised before?

  • [ ] I checked and didn't find a similar issue

:package: Have you read the Contributing Guidelines?

:sparkles: Are you willing to submit a PR?

Submission Process:

  • Ask the maintainers for assignment of the issue, you can request for assignment by commenting on the issue itself.
  • Once assigned, submit a pull request (PR).
  • Maintainers will review and provide feedback, if any.
  • Maintainers can unassign issues due to inactivity, read more here.

Refer here for Terms and conditions for the contest.

ImSagnik007 avatar Sep 25 '24 07:09 ImSagnik007

I’d like to take on this issue. @ImSagnik007 Could you please assign it to me ?

mohit07dec avatar Oct 03 '24 19:10 mohit07dec

Hey @mohit07dec Assigning this issue to you, thanks for participating!

gorakhnathy7 avatar Oct 04 '24 03:10 gorakhnathy7

Hi @gorakhnathy7, if this assignee is no longer working on this issue, feel free to assign it to me and I can take it on.

hex1c avatar Oct 18 '24 05:10 hex1c

Hey @mohit07dec Are you still working on this!

gorakhnathy7 avatar Oct 19 '24 00:10 gorakhnathy7

Yes @gorakhnathy7

mohit07dec avatar Oct 19 '24 13:10 mohit07dec

Hey @mohit07dec If you have any questions or need assistance, feel free to reach out in the community.

gorakhnathy7 avatar Oct 24 '24 06:10 gorakhnathy7