hyperswitch icon indicating copy to clipboard operation
hyperswitch copied to clipboard

[REFACTOR] Update AnalyticsPool to hold variables for tenant ID

Open lsampras opened this issue 9 months ago • 6 comments

Update the AnalyticsProvider (or AnalyticsConfig) to hold a variable for tenant-ID.

This can be achieved by simply adding a new field in the underlying structs for SqlxClient & ClickhouseClient. Update the AnalyticsPool constructor method to accept a Tenant-ID.

Tenant-ID can be a new type field backed by a string;

pub struct TenantID(String);

For now the AnalyticsPool can be initialized with a fixed tenantID "default"

lsampras avatar May 02 '24 10:05 lsampras

@lsampras are all the analytic issues open for outside collaborators?

Mohamed-Ayaan358 avatar May 03 '24 12:05 Mohamed-Ayaan358

All the issues are open for outside collaborators ideally (atleast for analytics), We add good-first-issue for relatively simpler issues...

Once you ask to be assigned on an issue (could be a good-first-issue or not) the author can decide on it (there can be dependency on other issues or pending discussion or other conditions)

@SanchithHegde correct me here in case we do have a specific label or convention...

lsampras avatar May 03 '24 13:05 lsampras

I would like to work on this.

RaghavRox avatar May 07 '24 14:05 RaghavRox

hey @lsampras can I get assigned for this issue.

subhajit20 avatar May 08 '24 13:05 subhajit20

I'll assign this issue to @RaghavRox if he is still interested since we try to follow first come, first serve when assigning issues.

Sry for the confusion @subhajit20 you can pick this up if @RaghavRox is no longer interested or can take a look at one of the below issues

  1. #4595
  2. #4525

lsampras avatar May 08 '24 14:05 lsampras

I'll assign this issue to @RaghavRox if he is still interested since we try to follow first come, first serve when assigning issues.

Sry for the confusion @subhajit20 you can pick this up if @RaghavRox is no longer interested or can take a look at one of the below issues

  1. [Feature] Add tenant-ID as a field to all KafkaStore events #4595
  2. [FEATURE] Adding Audit events for payment core operations #4525

Allright!!

subhajit20 avatar May 09 '24 04:05 subhajit20