hyperswitch icon indicating copy to clipboard operation
hyperswitch copied to clipboard

[FEATURE] Add support for sending additional metadata in the `MessagingInterface`

Open lsampras opened this issue 10 months ago • 8 comments

Feature Description

In the current implementation of message interface I can only send a Message & a timestamp associated with the message, There is no accomodation to send additional metadata about the message which isn't part of the data but could be propogated to the downstream implementations,

These could be used downstream as kafka headers or redis hashes or partition keys.

Possible Implementation

metadata can be a simplistic HashMap<String, String> and can be either accomodated as a new param in the MessagingInterface or a new method on the Message Interface.

The implementers of MessageInterface can handle it as follows

  1. Kafka Send the metadata as headers
  2. EventLogger Log the metadata as a separate key along with the raw data

Have you spent some time checking if this feature request has been raised before?

  • [X] I checked and didn't find a similar issue

Have you read the Contributing Guidelines?

Are you willing to submit a PR?

None

lsampras avatar Apr 26 '24 14:04 lsampras

I am interested in this

tanbirali avatar Apr 29 '24 05:04 tanbirali

Hey @tanbirali thanks for your interest. I'll assign this issue, you can ask for clarifications here or reach out on our slack/discord.

lsampras avatar Apr 29 '24 09:04 lsampras

whenever I am running the docker-compose up -d all the services are working but the hyperswitch-hyperswitch-server-1 is exiting everytime starting the container, how can I fix this

tanbirali avatar May 02 '24 04:05 tanbirali

Hey @tanbirali , Can you share the logs that are emitted on docker failure ? you can get them via docker compose logs hyperswitch-server..

Also these are the steps for running hyperswitch locally via docker compose you can walk through them again if anything is amiss...

There were some similar issues reported and solved in the discord can check if your issue is present there

lsampras avatar May 02 '24 07:05 lsampras

Hey @tanbirali ,

Are you still interested/working on this, Is there any clarification/help you need about this issue.

lsampras avatar May 08 '24 09:05 lsampras

I am working on it, will try to create a PR soon

tanbirali avatar May 09 '24 11:05 tanbirali

Sorry I am not able to run the project locally, I tried having a convo in the discord community, something or the other is not working for me, sorry for delaying it, I am trying in the mean time if anyone is willing to take this issue, please assign it to the individual

tanbirali avatar May 13 '24 15:05 tanbirali

Hey @tanbirali no worries, I'll keep the issue unassigned for now.

lsampras avatar May 16 '24 05:05 lsampras