hyperswitch
hyperswitch copied to clipboard
feat(connector): [Multisafepay] Add support for Ideal and Giropay
Type of Change
- [ ] Bugfix
- [X] New feature
- [ ] Enhancement
- [ ] Refactoring
- [ ] Dependency updates
- [ ] Documentation
- [ ] CI/CD
Description
Add iDEAL and Giropay payment processors in Multisafepay connector.
Whole description can be found in https://github.com/juspay/hyperswitch/discussions/4143 discussion.
Additional Changes
- [ ] This PR modifies the API contract
- [ ] This PR modifies the database schema
- [ ] This PR modifies application configuration/environment variables
Motivation and Context
Solves the issue #4397
How did you test it?
I have tested the Multisafe payment connector for Giropay and iDeal methods in Postman suit. You can find my fork of Postman's collection below. In Payments - Create iDeal Payment
and Payments - Create Giropay Direct
in Quick Start
are the requests for the payments.
iDeal
By requesting the iDeal payment method with "Ing" bank name, a redirection link can be found, redirecting to the test portal of Multisafepay, where we can see the bank name we selected.
Also, passing bank names not supported by iDeal raises an Error.
Not Passing the bank name in the payment_method_data
returns an error, too.
Giropay
Giropay doesn't support the direct method, so it is not compulsory to enter bank_name
into the payment_method_data
. After a successful request to Multisafepay, We will get a redirection link to the Mutisafepay payment's page.
Mutisafepay payment page.
Checklist
- [x] I formatted the code
cargo +nightly fmt --all
- [x] I addressed lints thrown by
cargo clippy
- [x] I reviewed the submitted code
- [ ] I added unit tests for my changes where possible
- [ ] I added a CHANGELOG entry if applicable
Hey @TakshPanchal, Your branch has conflicts. Please update it to main.
Hey @TakshPanchal, Your branch has conflicts. Please update it to main.
Yes, I am aware of that, working on it. Thank you.
#4397 Linking the issue
I think I have to do some changes after resolving these merge conflicts. I will look into that.
I have resolved the conflicts and ran clippy
. At the end code is compiled and ran successfully.
Hey @TakshPanchal , Could you please resolve the conflicts ?
@SamraatBansal Can You please review my changes and comments.
@TakshPanchal Could you please resolve the merge conflicts?
@SanchithHegde I resolved all the conflicts.