hyperswitch icon indicating copy to clipboard operation
hyperswitch copied to clipboard

feat(connector): [Multisafepay] Add support for Ideal and Giropay

Open TakshPanchal opened this issue 10 months ago • 6 comments

Type of Change

  • [ ] Bugfix
  • [X] New feature
  • [ ] Enhancement
  • [ ] Refactoring
  • [ ] Dependency updates
  • [ ] Documentation
  • [ ] CI/CD

Description

Add iDEAL and Giropay payment processors in Multisafepay connector.

Whole description can be found in https://github.com/juspay/hyperswitch/discussions/4143 discussion.

Additional Changes

  • [ ] This PR modifies the API contract
  • [ ] This PR modifies the database schema
  • [ ] This PR modifies application configuration/environment variables

Motivation and Context

Solves the issue #4397

How did you test it?

I have tested the Multisafe payment connector for Giropay and iDeal methods in Postman suit. You can find my fork of Postman's collection below. In Payments - Create iDeal Payment and Payments - Create Giropay Direct in Quick Start are the requests for the payments.

iDeal

By requesting the iDeal payment method with "Ing" bank name, a redirection link can be found, redirecting to the test portal of Multisafepay, where we can see the bank name we selected. image image Also, passing bank names not supported by iDeal raises an Error. image

Not Passing the bank name in the payment_method_data returns an error, too. image

Giropay

Giropay doesn't support the direct method, so it is not compulsory to enter bank_name into the payment_method_data. After a successful request to Multisafepay, We will get a redirection link to the Mutisafepay payment's page. image

Mutisafepay payment page. image

Run In Postman

Checklist

  • [x] I formatted the code cargo +nightly fmt --all
  • [x] I addressed lints thrown by cargo clippy
  • [x] I reviewed the submitted code
  • [ ] I added unit tests for my changes where possible
  • [ ] I added a CHANGELOG entry if applicable

TakshPanchal avatar Apr 19 '24 08:04 TakshPanchal

Hey @TakshPanchal, Your branch has conflicts. Please update it to main.

srujanchikke avatar Apr 22 '24 09:04 srujanchikke

Hey @TakshPanchal, Your branch has conflicts. Please update it to main.

Yes, I am aware of that, working on it. Thank you.

TakshPanchal avatar Apr 22 '24 09:04 TakshPanchal

#4397 Linking the issue

TakshPanchal avatar Apr 22 '24 09:04 TakshPanchal

I think I have to do some changes after resolving these merge conflicts. I will look into that.

TakshPanchal avatar Apr 22 '24 10:04 TakshPanchal

I have resolved the conflicts and ran clippy. At the end code is compiled and ran successfully.

TakshPanchal avatar Apr 22 '24 13:04 TakshPanchal

Hey @TakshPanchal , Could you please resolve the conflicts ?

srujanchikke avatar May 07 '24 07:05 srujanchikke

@SamraatBansal Can You please review my changes and comments.

TakshPanchal avatar Jun 04 '24 10:06 TakshPanchal

@TakshPanchal Could you please resolve the merge conflicts?

SanchithHegde avatar Jun 04 '24 13:06 SanchithHegde

@SanchithHegde I resolved all the conflicts.

TakshPanchal avatar Jun 06 '24 14:06 TakshPanchal