hyperswitch icon indicating copy to clipboard operation
hyperswitch copied to clipboard

[REFACTOR] Update HTTP Method for Retrieving GSM Records (/gsm/get) API to GET and Retrieve Fields via Query Parameters Instead of Request Body

Open sai-harsha-vardhan opened this issue 1 year ago • 8 comments

Feature Description

Currently, the GSM Retrieve API (/gsm/get) accepts requests using the POST method, with fields being submitted in the request body. Ideally, it should be a GET method API, with fields accepted as query parameters

Possible Implementation

Change the HTTP method of the GSM Retrieve API (/gsm/get) to GET and modify it to accept fields in the query parameters

sai-harsha-vardhan avatar Nov 09 '23 14:11 sai-harsha-vardhan

I would like to work on this :)

goku321 avatar Nov 10 '23 05:11 goku321

Sure, @goku321, I've assigned it to you. Thanks for your interest. Feel free to use the issue thread or our Discord channel if you have any queries.

sai-harsha-vardhan avatar Nov 10 '23 07:11 sai-harsha-vardhan

Sure, @sai-harsha-vardhan. Thanks :)

goku321 avatar Nov 10 '23 14:11 goku321

Hey @goku321, If you are stuck / need some help, please feel free to ask queries here / our discord channel. Thanks!

sai-harsha-vardhan avatar Dec 12 '23 07:12 sai-harsha-vardhan

Hi @sai-harsha-vardhan Thanks for the follow up. I started making the changes but then got caught up with some other things. I will try to finish this within this week. Will reach out if I have any questions. Thanks :)

goku321 avatar Dec 19 '23 06:12 goku321

@goku321, Thanks for the update!

sai-harsha-vardhan avatar Dec 19 '23 06:12 sai-harsha-vardhan

Hi, I would like to ask if @goku321 is still working on this and if not, @sai-harsha-vardhan is this still something someone is working on? Because we need this so the openapi spec is correct, and does not generate a warning about a body in a get; delete request.

Thanks

GunniBusch avatar Apr 19 '24 23:04 GunniBusch

Hi @GunniBusch I made multiple attempts but couldn't conclude it due to a busy schedule. Please feel free to take this up. I would really appreciate that. Thanks for your patience

goku321 avatar Apr 21 '24 18:04 goku321