hyperswitch icon indicating copy to clipboard operation
hyperswitch copied to clipboard

[FEATURE] move connector config to a separate file

Open Narayanbhat166 opened this issue 1 year ago • 7 comments

Feature Description

Currently all the connector configuration is present in the development.toml file. But this configuration is not developer specific, this remains the same whoever uses it, this configuration is based on the application and it should not be tweaked by the developer or else it would cause some features to not work.

Possible Implementation

Move the configuration to a separate file and if possible in a better format ( the layout and keys can be changed as per the needs, but file format has to be TOML only ) so that the application can read it easily. After making this change, all the places where this config is read has to be changed to read from a single file.

Have you spent some time to check if this feature request has been raised before?

  • [X] I checked and didn't find similar issue

Have you read the Contributing Guidelines?

Are you willing to submit a PR?

No, but I'm happy to collaborate on a PR with someone else

Narayanbhat166 avatar May 10 '23 10:05 Narayanbhat166

i can take it

MehmetTerc avatar May 10 '23 14:05 MehmetTerc

I have assigned this issue to you. Let me know if you need more clarifications on this.

Narayanbhat166 avatar May 10 '23 14:05 Narayanbhat166

can you describe the issue a little bit clearer

MehmetTerc avatar May 10 '23 15:05 MehmetTerc

We use this file to store all the developer related configuration like, the database password, log level etc. There is also connector ( you can treat connector as a payment gateway going forward ) configuration present in it. This connector configuration tells about the base url that should be used when calling the connector, List of countries and currencies supported by a connector etc. The connector configuration is developer independent and remains the same whoever uses it. It should not be changed unless you know what you are dealing with.

So it is better to move these connector related configuration to a separate file and make necessary changes to read this file at the start of application.

Few examples of connnector configuration keys are

[connectors.supported]
[connectors]
[connectors.zen]
[bank_config.eps]
[bank_config.ideal]

[pm_filters.stripe]
[pm_filters.worldpay]

[pm_filters.forte]
[connector_customer]
[tokenization]

Narayanbhat166 avatar May 10 '23 15:05 Narayanbhat166

hey @Narayanbhat166 can I take this issue up as there has not been any updates?

subhajit20 avatar Apr 11 '24 14:04 subhajit20

Hey @subhajit20, Thanks for showing interest. since I have not heard back from the pervious contributor, you can take this up. Feel free to reach out to me if you have any doubts.

Narayanbhat166 avatar Apr 18 '24 07:04 Narayanbhat166

hey @Narayanbhat166 can you please review my pr once you have time.

subhajit20 avatar Apr 18 '24 14:04 subhajit20