hyperswitch-web icon indicating copy to clipboard operation
hyperswitch-web copied to clipboard

test: add e2e test for card payment for Adyen connector successful flow

Open shubhamchasing opened this issue 1 year ago • 14 comments

Type of Change

  • [ ] Bugfix
  • [x] New feature
  • [ ] Enhancement
  • [ ] Refactoring
  • [ ] Dependency updates
  • [ ] Documentation
  • [ ] CI/CD

Description

Closes: hyperswitch/issues/6082

  1. Added command getIframeElement as cy.iframe as it can only be applied to exactly one iframe at a time edit: using cy.iframe see comment #issuecomment-2436324828
  2. Added e2e test cases for successful card payment for the Adyen connector

How did you test it?

Screenshot from 2024-10-24 07-51-44

Checklist

  • [x] I ran npm run re:build
  • [x] I reviewed submitted code
  • [ ] I added unit tests for my changes where possible

shubhamchasing avatar Oct 24 '24 02:10 shubhamchasing

Review changes with  SemanticDiff

Changed Files
File Status
  cypress-tests/cypress/support/types.ts  100% smaller
  cypress-tests/cypress/support/utils.ts  29% smaller
  cypress-tests/cypress/e2e/adyen-card-flow-e2e-test.cy.ts  0% smaller

semanticdiff-com[bot] avatar Oct 24 '24 02:10 semanticdiff-com[bot]

@Sanskar2001 please review

shubhamchasing avatar Oct 24 '24 02:10 shubhamchasing

I wanna highlight one thing previously I used get because cy.iframe sometimes gives error with iframe selector .adyen-checkout__iframe, I could not find out any specific reason for it but with iframe selector .adyen-checkout__iframe--threeDSIframe it is working fine. I have made the necessary changes.

@Sanskar2001 @seekshiva please look at it, thank you!

Error while using .adyen-checkout__iframe Screenshot from 2024-10-25 00-27-43

shubhamchasing avatar Oct 24 '24 20:10 shubhamchasing

I will look requested changes in a few days.

shubhamchasing avatar Nov 05 '24 11:11 shubhamchasing

@Sanskar2001 can you please respond to my comments, I wanna close this PR soon

shubhamchasing avatar Nov 12 '24 07:11 shubhamchasing

@Sanskar2001 can you please respond to my comments, I wanna close this PR soon

Hey @shubhamchasing, your task involved testing a normal card payment i.e. no 3DS flow meaning you don't have to test the redirection flow to Adyen Simulator. This task is assigned to someone else.

Could you please resolve the comments and take a pull from main, so that we can proceed?

Thanks!

Sanskar2001 avatar Nov 12 '24 08:11 Sanskar2001

@Sanskar2001 is there any issue from the backend because I am getting 403 error, I also tried new creds too but issue persit

shubhamchasing avatar Nov 12 '24 12:11 shubhamchasing

@Sanskar2001 is there any issue from the backend because I am getting 403 error, I also tried new creds too but issue persit

@shubhamchasing Yes, there is some maintenance going on. Please try again in some time.

Sanskar2001 avatar Nov 12 '24 12:11 Sanskar2001

@Sanskar2001 is there any issue from the backend because I am getting 403 error, I also tried new creds too but issue persit

@shubhamchasing Yes, there is some maintenance going on. Please try again in some time.

@shubhamchasing The maintenance is over. You can start working on it now.

Sanskar2001 avatar Nov 12 '24 13:11 Sanskar2001

@Sanskar2001 please review

shubhamchasing avatar Nov 12 '24 14:11 shubhamchasing

@Sanskar2001 @seekshiva hey guys please review

shubhamchasing avatar Nov 19 '24 11:11 shubhamchasing

Requested changes are done

shubhamchasing avatar Nov 19 '24 11:11 shubhamchasing

Hey guys @Sanskar2001 @seekshiva, I understand you guys must be busy and dealing with a lot of stuff but can you please take a moment to review this PR again? Apologies if it seems like spam but in good spirit of Open Source Contribution I like to make sure whatever contribution I make should reach its goal.

shubhamchasing avatar Dec 05 '24 18:12 shubhamchasing

Hi @PritishBudhiraja can you please take a look at this PR

shubhamchasing avatar Jan 12 '25 18:01 shubhamchasing

Conflicts needs to be resolved. Closing this PR till then

PritishBudhiraja avatar Jul 01 '25 05:07 PritishBudhiraja