hyperswitch-web icon indicating copy to clipboard operation
hyperswitch-web copied to clipboard
verified publisher icon juspay

fix: added validation for empty clientSecret in completeUpdateIntent

Open s-vamshi opened this issue 2 months ago • 9 comments

Type of Change

  • [x] Bugfix
  • [ ] New feature
  • [ ] Enhancement
  • [ ] Refactoring
  • [ ] Dependency updates
  • [ ] Documentation
  • [ ] CI/CD

Description

Fixes #9355

Added validation to check whether clientSecret is empty if its length is empty if it is then returning else continue with the existing flow

How did you test it?

Checklist

  • [x] I ran npm run re:build
  • [x] I reviewed submitted code
  • [ ] I added unit tests for my changes where possible

s-vamshi avatar Oct 01 '25 12:10 s-vamshi

Review changes with  SemanticDiff

semanticdiff-com[bot] avatar Oct 01 '25 12:10 semanticdiff-com[bot]

@aritro2002 can you please review now as completeUpdateIntent return type is defined as promise

completeUpdateIntent: string => promise<JSON.t>,

i had to use if else block and return a resolved promise containing an empty JSON object.

s-vamshi avatar Oct 07 '25 16:10 s-vamshi

@aritro2002 can you please review this pr?

s-vamshi avatar Oct 09 '25 05:10 s-vamshi

@aritro2002 can you please review this pr?

s-vamshi avatar Oct 10 '25 06:10 s-vamshi

@aritro2002 can you please review this pr?

s-vamshi avatar Oct 13 '25 15:10 s-vamshi

@aritro2002 can you please review this pr

s-vamshi avatar Oct 17 '25 13:10 s-vamshi

@aritro2002 can you please review this pr?

s-vamshi avatar Oct 22 '25 04:10 s-vamshi

@sakksham7 done with suggested changes can you please review in your free time?

s-vamshi avatar Oct 25 '25 17:10 s-vamshi

Hey @s-vamshi, Thank you for your contribution! Please fill this form: Link

AbhishekChorotiya avatar Oct 31 '25 11:10 AbhishekChorotiya