Juse Less
Juse Less
I have a few ideas, that I can write down next week, or so, as I have some work commitments myself (started a tight 2 week sprint today even). v1...
Note: I haven't looked through it all just yet, and haven't looked at the progress of the v2 branch. I have to say, though - I'm liking many of the...
@michaeldyrynda Have you tried with both Intelephense and Phpactor? My experience is that Phpactor works far better. It _shouldn't_ be the reason, but I also realise that the return type...
I did some tests with the proposed solution, and it works with Phpactor in Neovim, albeit with some adjustments. I haven't tried Intelephense, though. I set up a fresh Neovim...
Ohh. Right. I believe it's complaining when passing null (or nothing), because T doesn't exist without the class string. So the check should be to check if `$dto` is null,...
@Sammyjo20 I wouldn't say it's a discussion. It's a limitation in PhpStorm itself. Adding this shouldn't break anything in PhpStorm, from I've seen. But will add autocompletion for other editors...
I switch between PhpStorm and Neovim quite a lot, depending on what I do, and where. I see incompatibilities like these, almost always in PhpStorm. It's indeed a shame. 😕...
@michaeldyrynda Can you just double-check that the changes proposed in the PR works? The reason I'm asking is because I tested them just now (your latest commit, without the style...
Hi! It'd be easier if you shared the request class. But assuming you're [using the right body trait](https://docs.saloon.dev/the-basics/request-body-data), this is an issue with Intelephense. The [`JsonBodyRepository::setJsonFlags()`](https://github.com/saloonphp/saloon/blob/e669e8554f275c83aaa0b7d9d219b442e269f75f/src/Repositories/Body/JsonBodyRepository.php#L28) method is defined right...
I'd need to double-check the difference between v2 and v3. But if I recall correctly, we had interfaces for each body type, which then type-hinted with the appropriate body type....