qView icon indicating copy to clipboard operation
qView copied to clipboard
verified publisher icon jurplel

String fixes

Open comradekingu opened this issue 3 years ago • 6 comments

comradekingu avatar Jan 13 '22 11:01 comradekingu

@jurplel Anything wrong with this?

comradekingu avatar Dec 29 '22 14:12 comradekingu

hi there, I left some comments a while ago and I just realized I never submitted them, I am sorry!

jurplel avatar Dec 29 '22 14:12 jurplel

Thank you for the improvements!

Additionally:

  • an ellipses was missed in openwith.cpp.
  • the translation files should be updated as well

jurplel avatar Jan 11 '23 16:01 jurplel

Closed due to inactivity

jurplel avatar Oct 20 '23 04:10 jurplel

@jurpiel Sorry I missed this. Fixed in patch-1. I can run the scripts once home again. Too much back and forth to get the codes and two-factors working.

comradekingu avatar Oct 20 '23 12:10 comradekingu

In addition to my review requests, I think this will require a merge and changing more ellipses since there are more in the codebase now.

If you'd like I would be happy to take over this PR when time permits

jurplel avatar Oct 24 '23 01:10 jurplel

closed due to inactivity

jurplel avatar May 06 '24 19:05 jurplel