rtc icon indicating copy to clipboard operation
rtc copied to clipboard

Add benchmarks folder

Open echarles opened this issue 5 years ago • 3 comments

Fixes https://github.com/jupyterlab/rtc/issues/57

echarles avatar Aug 15 '20 12:08 echarles

Opened this more to start a discussion about the need to have such benchmarks, based on following thought:

  • I don't think copying an existing benchmark is the best thing and maybe contributing to the initial repo would sound more logical. On the other hand it gives more freedom to let evolve here.
  • https://github.com/jupyterlab/lumino/tree/8726968af142e44ca61ba28ab5f9f6911f34ee3f/datastore-benchmarks commit was not merged into lumino master. I am happy to get any benchmark in lumino repo or in this rtc repo.

Sound like we have various options:

  • Contributed lumino comparison to https://github.com/dmonad/crdt-benchmarks
  • Merge comparison into lumino
  • Merge comparison in this repo
  • Develop from scratch a benchmark tool in this repo

Any other options? Thoughts?

echarles avatar Aug 17 '20 11:08 echarles

Contributing upstream would be my preference! That would give more visibility to lumino to other folks and get their feedback and involvement.

saulshanabrook avatar Aug 20 '20 12:08 saulshanabrook

Contributing upstream would be my preference! That would give more visibility to lumino to other folks and get their feedback and involvement.

@ellisonbg You have developed the lumino benchmark. What would be your thoughts on this?

echarles avatar Aug 20 '20 12:08 echarles