lumino icon indicating copy to clipboard operation
lumino copied to clipboard

Published 20 hours ago • verified publisher icon jupyterlab

Add `.min.js` versions to each package's build

Open afshin opened this issue 3 years ago • 4 comments

The package.json entries for jsdelivr and unpkg currently reference dist/index.min.js which no longer exists after updating many of the devDependencies and support needs to be re-added.

afshin avatar Aug 08 '22 22:08 afshin

@afshin I can look into this. Can you assign this to me.

3coins avatar Aug 10 '22 16:08 3coins

@afshin I just installed and ran yarn build:dist which generated the dist/index.min.js files inside individual packages. Is there anything more expected here?

3coins avatar Aug 12 '22 00:08 3coins

I can also verify that https://unpkg.com/@lumino/[email protected]/dist/index.min.js is a valid url.

blink1073 avatar Aug 12 '22 01:08 blink1073

I thought that I had broken this for Lumino 2, but I guess that means this is not an issue. Thanks for checking it out!

On Fri, 12 Aug 2022 at 02:38 Steven Silvester @.***> wrote:

I can also verify that @.@./dist/index.min.js is a valid url.

— Reply to this email directly, view it on GitHub https://github.com/jupyterlab/lumino/issues/344#issuecomment-1212649214, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABG6KIO3DMCUDIJPRVU4BDVYWTIXANCNFSM556YBRFA . You are receiving this because you were mentioned.Message ID: @.***>

afshin avatar Aug 12 '22 07:08 afshin