jupyterlab icon indicating copy to clipboard operation
jupyterlab copied to clipboard

Add option to dismiss dialog

Open RRosio opened this issue 1 year ago • 1 comments
trafficstars

References

Related to https://github.com/jupyterlab/jupyterlab/issues/8374

Code changes

This PR uses the showDialog function to display an error message with a checkbox giving the user the option to dismiss the popup dialog for the remainder of their tab session.

User-facing changes

The user will now see a clickable checkbox that allows them to dismiss the error dialog informing them their connection to the server was lost.

Screenshot 2024-05-01 at 12 10 47 AM

Backwards-incompatible changes

Not applicable

RRosio avatar May 01 '24 07:05 RRosio

Thanks for making a pull request to jupyterlab! To try out this branch on binder, follow this link: Binder

jupyterlab-probot[bot] avatar May 01 '24 07:05 jupyterlab-probot[bot]

Thank you for your review @JasonWeill! OH I think I missed checking for that but I will update this with the appropriate fix for that, thank you for letting me know!

RRosio avatar May 09 '24 15:05 RRosio

I am not sure that the failing CI job, check_release is related to these changes. I have seen it fail for at least one other dependabot PR with a few pip dependency updates.

RRosio avatar Jun 05 '24 22:06 RRosio

The check_release failure is unrelated, tracking it here: https://github.com/jupyterlab/jupyterlab/issues/16448

krassowski avatar Jun 07 '24 08:06 krassowski

@RRosio is it ready for review?

krassowski avatar Jun 07 '24 08:06 krassowski

@krassowski, it should be ready for review now!

RRosio avatar Jun 10 '24 22:06 RRosio