jupyterlab
jupyterlab copied to clipboard
Add option to dismiss dialog
References
Related to https://github.com/jupyterlab/jupyterlab/issues/8374
Code changes
This PR uses the showDialog function to display an error message with a checkbox giving the user the option to dismiss the popup dialog for the remainder of their tab session.
User-facing changes
The user will now see a clickable checkbox that allows them to dismiss the error dialog informing them their connection to the server was lost.
Backwards-incompatible changes
Not applicable
Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link:
Thank you for your review @JasonWeill! OH I think I missed checking for that but I will update this with the appropriate fix for that, thank you for letting me know!
I am not sure that the failing CI job, check_release is related to these changes. I have seen it fail for at least one other dependabot PR with a few pip dependency updates.
The check_release failure is unrelated, tracking it here: https://github.com/jupyterlab/jupyterlab/issues/16448
@RRosio is it ready for review?
@krassowski, it should be ready for review now!