jupyterlab
jupyterlab copied to clipboard
Case insensitive match for completion items filtering
Missing a letter is allowed by matchSumOfSquares so it makes more sense to make filtering case insensitive.
Thanks for making a pull request to jupyterlab!
To try out this branch on binder, follow this link:
Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:
Sure but I am a bit busy right now. I will have a look when I come back from holidays! :)
@christophediprima did you have a chance to take another look? It seems to have missed to 4.2 merge window, I will switch this PR to draft.
@christophediprima are you still interested in finishing this one? There is about 2 weeks left to complete it before 4.3 otherwise we will need to bump it to next release or close out to signal that anyone else can open a fresh PR if they would like to contribute this option.
Closing due to lack of response - if anyone would like to work on it please open a new pull request addressing the changes requested above :)