jupyterlab icon indicating copy to clipboard operation
jupyterlab copied to clipboard

Add a setter to TagWidget's parent

Open brichet opened this issue 3 years ago • 1 comments

A getter has been added to the TagWidget's parent attribute in v4.0.0a28, without setter (which should rely to its parent class).

It look like Typescript does not allow overriding the getter without the setter and vice versa.

At the end, it is not possible to add a new tag to a cell :

image

Code changes

Add a setter to TagWidget's parent attribute.

Backwards-incompatible changes

None

brichet avatar Sep 22 '22 11:09 brichet

Thanks for making a pull request to jupyterlab! To try out this branch on binder, follow this link: Binder

jupyterlab-probot[bot] avatar Sep 22 '22 11:09 jupyterlab-probot[bot]

Congrats on your first merged pull request in this project! :tada: congrats Thank you for contributing, we are very proud of you! :heart:

welcome[bot] avatar Sep 26 '22 14:09 welcome[bot]