jupyterlab-github icon indicating copy to clipboard operation
jupyterlab-github copied to clipboard

Make GITHUB_API on client configurable

Open ktong opened this issue 7 years ago • 3 comments

Our GHE can be connect directly from browser. So if GITHUB_API is configurable, then we do not need server side proxy.

ktong avatar Jul 18 '18 19:07 ktong

Do you connect with an access token? The primary reason for the server-side proxy is security: since the access token or client_secret are effectively passwords to a user's GitHub account, it is unsafe to store them client-side.

ian-r-rose avatar Jul 18 '18 19:07 ian-r-rose

It does not need access token as user already accesses GHE. Probably Cookie enables access of GHE. If not, access token in access URL also acceptable.

ktong avatar Jul 18 '18 19:07 ktong

I have no objection to this enhancement (so long as there is no security issue), but I can't really do it myself without good access to a GHE account. PRs welcome though, and I'm happy to help!

ian-r-rose avatar Jul 18 '18 19:07 ian-r-rose