jupyterlab-github icon indicating copy to clipboard operation
jupyterlab-github copied to clipboard

Use the token provided in the settings for frontend issued requests

Open jtpio opened this issue 1 year ago • 0 comments

Problem

Currently, if the frontend part of the jupyterlab-github extension is used only (like in JupyterLite), the token provided via the settings does not seem to be taken into account.

This is likely because the token is appended to the URL only if the proxy (server extension) is used, and the real GitHub request made from the server extension:

https://github.com/jupyterlab/jupyterlab-github/blob/6ab46858aa5dc0b93510b8fdb52e9066178847ea/src/contents.ts#L542-L550

In the following screencast we see there is no information about the provided token in the requests to the GitHub API:

jupyterlab-github-request-notoken.webm

Proposed Solution

It would be useful to allow for using the token also for requests made from the JupyterLab UI directly, in scenarios where the server extension is not installed.

Additional context

This can be tested using a JupyterLite deployment with jupyterlab-github installed, for example: https://jupyterlite.readthedocs.io/en/stable/_static/lab/index.html

cc @rpwagner since we were looking into this in-person yesterday at the Jupyter Open Studio Day in NYC

jtpio avatar Apr 30 '24 14:04 jtpio