jupyterlab-git icon indicating copy to clipboard operation
jupyterlab-git copied to clipboard

Published 20 hours ago • verified publisher icon jupyterlab

Incorrect DocRegistry icon showing up

Open krassowski opened this issue 3 years ago • 0 comments

Description

When ipydrawio which adds a custom DocRegistry FileType (which was only recently fixed https://github.com/jupyterlab/jupyterlab/pull/9958) is installed an incorrect icon is shown for notebook.

Reproduce

  1. Install JupyterLab 3.1 pre-release or the most recent JupyterLab 3.0.x (not sure when exactly the changes were backported, but it was in March).
  2. Install ipydrawio 1.0 or newer (earlier it had https://github.com/deathbeds/ipydrawio/issues/21)
  3. Edit a tracked notebook
  4. See that icon in git panel shows ipydrawio icon rather than notebook icon even though the notebook has priority over ipydrawio (and correct icon is shown in file browser)

Screenshot from 2021-06-11 11-03-37

Screenshot from 2021-06-11 11-09-17

  • [ ] this also hints at a possible bug in the context menu as the icon for ipydrawio is not shown next to "Diagram Notebook (Notebook)" entry but it probably should? (TODO check)

Expected behavior

Notebook icon is shown

Context

  • jupyterlab 3.1.0a12
  • jupyterlab-git 0.30.1
  • ipydrawio 1.1.0

krassowski avatar Jun 11 '21 10:06 krassowski