jupyterlab-desktop icon indicating copy to clipboard operation
jupyterlab-desktop copied to clipboard

No "undo" on Mac in a notebook cell

Open oliviermarti opened this issue 2 years ago • 16 comments

Description

I can not find any key combination that perform an undo in a cell. For any kind of cell : python, markdown or raw.

I've tried crtl-z, cmd-z, ctrl-shift-zand cmd-shift-z. No success. It makes JupyterLab unusable :-(

Context

  • Operating System and version: Mac OSX 13.3.1 Ventura
  • JupyterLab-Desktop version: 3.6.2-1
  • Installer: .dmg

Thank's for your help

oliviermarti avatar Apr 18 '23 09:04 oliviermarti

@mbektas Are there any other commands in JupyterLab Desktop that do what @oliviermarti describes?

JasonWeill avatar Apr 18 '23 16:04 JasonWeill

@krassowski pointed out that https://github.com/jupyterlab/jupyterlab/issues/10791 provides info about applying "undo" and "redo" to individual cells' contents. Does this address your issue?

JasonWeill avatar Apr 18 '23 17:04 JasonWeill

I've found information about this experimentalDisableDocumentWideUndoRedo option in StackOverFlow. I've tried to play with it but it doesn't change anything. It's an option about having an undo/redo local to a cell, or more global. It has no effect when undo/redo is not working at all.

PS : I've found the option in the json settings editor view, but not in the default view with click boxes .. (??)

Olivier

oliviermarti avatar Apr 19 '23 07:04 oliviermarti

I'm not sure this is exactly the same issue, but this is what happens on my Mac installation: CMD+Z and CTRL+Z look binded at higher level (Electron? This is not a standard Mac shortcut except for undo AFAIK). Typically, they will close the current tab when pressed.

I've had success rebinding undo to OPTION+Z (in Settings > Advanced settings editor > Keyboard Shortcuts), as there does not seem to be any other conflicting keybinding. @oliviermarti you might want to try that as a temporary solution.

  • Operating System and version: Mac OSX 13.3.1(a) Ventura
  • JupyterLab-Desktop version: 3.6.3-2
  • Installer: .dmg

abulte avatar May 13 '23 06:05 abulte

@abulte I'm a bit puzzled with the advanced syntax editor :-( Could you give me the exact lines you add ? Thank in advance Olivier

oliviermarti avatar May 16 '23 07:05 oliviermarti

I just click on "Add" on the shortcut I'm interested in, and then input my key combination (eg type OPTION+Z).

Capture d’écran 2023-05-16 à 09 48 44

abulte avatar May 16 '23 07:05 abulte

@oliviermarti I am not able to reproduce this issue. Cmd + Z works fine for me for undoing text input in cells.

mbektas avatar May 17 '23 16:05 mbektas

@mbektas I can reproduce, maybe a Mac OS version or architecture (Silicon here) issue? I'm on a fresh Mac OS install so there should not be any funny stuff in my config.

  • Operating System and version: Mac OSX 13.3.1(a) Ventura
  • JupyterLab-Desktop version: 3.6.3-2
  • Installer: .dmg
  • Architecture : Silicon M1

abulte avatar May 17 '23 17:05 abulte

I tried it on an Apple silicon as well and still cannot reproduce. Do other shortcuts such as Cmd + A (Select all) work for you?

mbektas avatar Jun 07 '23 04:06 mbektas

Yes. Cmd+A, Cmd+C, Cmd+V, Cmd+X are ok.

Olivier

oliviermarti avatar Jun 07 '23 06:06 oliviermarti

Yes. Cmd+A, Cmd+C, Cmd+V, Cmd+X are ok.

Olivier

Did you find a solution to your problem ? I'm experiencing the same behavior on my MacBook Pro (M2)...

abdelhakel avatar Aug 22 '23 12:08 abdelhakel

I'm presently using option-Z for cancel. Didn't find any proper solution :-(

Olivier

oliviermarti avatar Aug 22 '23 13:08 oliviermarti

Could you retry with the latest version v4.0.5-1? There wer some Electron.js updates which might also include a fix for this issue.

mbektas avatar Sep 12 '23 15:09 mbektas

@mbektas still no luck here with this version

abulte avatar Sep 12 '23 16:09 abulte

@mbektas still no luck here with this version

Same for me. I've tried to reset to settings to defaults. Olivier

oliviermarti avatar Sep 13 '23 11:09 oliviermarti

Could you retry with the latest version v4.0.5-1? There wer some Electron.js updates which might also include a fix for this issue.

Not working for me. So, on the same laptop Jupyter Lab "CMD-Z" is working fine". But not with Jupyterlab Desktop

abdelhakel avatar Sep 13 '23 13:09 abdelhakel