jupyter-ai icon indicating copy to clipboard operation
jupyter-ai copied to clipboard

Published 20 hours ago • verified publisher icon jupyterlab

Precommit does not lint typescript files

Open krassowski opened this issue 1 year ago • 0 comments
trafficstars

When pre-commit is configured, contributors should not be expected to lint manually. However only python linters are included in the pre-commit config:

https://github.com/jupyterlab/jupyter-ai/blob/4b45ec23f3e16a0fa29718eefaf37064f59cafe6/.pre-commit-config.yaml#L1-L58

Is this intentional or an omission? Happy to open a PR with a fix if there is an agreement on it.

krassowski avatar Sep 07 '24 10:09 krassowski