jupyter-ai icon indicating copy to clipboard operation
jupyter-ai copied to clipboard

`/learn` has unused `-v/--verbose` option

Open krassowski opened this issue 1 year ago • 2 comments
trafficstars

Description

https://github.com/jupyterlab/jupyter-ai/blob/2019571d916549262d04b3c02ec13e043935a7d4/packages/jupyter-ai/jupyter_ai/chat_handlers/learn.py#L44

is not used at all. It used to be used for "Loading and splitting files for" message a year ago:

https://github.com/jupyterlab/jupyter-ai/blob/1bc264ef6507574a8b22e8b5b62aebaf63f725c3/packages/jupyter-ai/jupyter_ai/actors/learn.py#L82-L83

but since it was refactored to:

https://github.com/jupyterlab/jupyter-ai/blob/2019571d916549262d04b3c02ec13e043935a7d4/packages/jupyter-ai/jupyter_ai/chat_handlers/learn.py#L154

it is not used anywhere anymore.

Context:

  • added in https://github.com/jupyterlab/jupyter-ai/pull/94
  • regressed in https://github.com/jupyterlab/jupyter-ai/pull/821

krassowski avatar Jul 09 '24 11:07 krassowski

Should we remove this option? Or is there an intent to add a verbose mode in near term?

krassowski avatar Jul 10 '24 15:07 krassowski

@krassowski I think it's fine to keep the option for now and reserve it for future use. We may want to add more extensive logging to /learn in the future.

dlqqq avatar Jul 10 '24 17:07 dlqqq