jupyter-ai icon indicating copy to clipboard operation
jupyter-ai copied to clipboard

Inline completion request does not include path when kernel is dead

Open krassowski opened this issue 1 year ago • 1 comments
trafficstars

Description

We are getting the path from session, but the session may be disposed after restarting server.

Reproduce

https://github.com/jupyterlab/jupyter-ai/blob/fcb2d7111f35e363f76afd28aea581500aad89e9/packages/jupyter-ai/src/completions/provider.ts#L106

Expected behavior

Inline completion path is available when kernel is dead too.

Context

jupyter-ai 2.23

krassowski avatar Sep 17 '24 14:09 krassowski

We could probably try to do better with context.widget and some type checks. Or maybe this should be exposed in IInlineCompletionContext directly upstream?

krassowski avatar Sep 17 '24 14:09 krassowski

Closing as a duplicate of https://github.com/jupyterlab/jupyter-ai/issues/1359 fixed by https://github.com/jupyterlab/jupyter-ai/pull/1361?

krassowski avatar Jul 08 '25 11:07 krassowski