extension-examples icon indicating copy to clipboard operation
extension-examples copied to clipboard

Add check on CI to compare more files

Open fcollonval opened this issue 4 years ago • 3 comments

Fixes #120

This approach uses the suggestion of applying the upgrade script

fcollonval avatar Feb 11 '21 18:02 fcollonval

Should we copy the following files in the upgrade script:

      - name: Check config files
        if: steps.filter.outputs.extension == 'true'
        run: |
          diff basics/hello-world/tsconfig.json ${EXAMPLE_FOLDER}/tsconfig.json
          diff basics/hello-world/.eslintignore ${EXAMPLE_FOLDER}/.eslintignore
          diff basics/hello-world/.eslintrc.js ${EXAMPLE_FOLDER}/.eslintrc.js
          diff basics/hello-world/.gitignore ${EXAMPLE_FOLDER}/.gitignore

so that this check can be removed?

fcollonval avatar Feb 12 '21 07:02 fcollonval

This is ready for review

fcollonval avatar Feb 14 '21 14:02 fcollonval

Should we copy the following files in the upgrade script:

Would that affect how the upgrade is script is run locally? For example would we need to set the EXAMPLE_FOLDER variable?

Maybe it's fine to keep them separate for now.

jtpio avatar Feb 18 '21 10:02 jtpio

Closing as the structure evolved quite a lot

fcollonval avatar Jun 14 '23 12:06 fcollonval