extension-examples
extension-examples copied to clipboard
Add check on CI to compare more files
Fixes #120
This approach uses the suggestion of applying the upgrade script
Should we copy the following files in the upgrade script:
- name: Check config files
if: steps.filter.outputs.extension == 'true'
run: |
diff basics/hello-world/tsconfig.json ${EXAMPLE_FOLDER}/tsconfig.json
diff basics/hello-world/.eslintignore ${EXAMPLE_FOLDER}/.eslintignore
diff basics/hello-world/.eslintrc.js ${EXAMPLE_FOLDER}/.eslintrc.js
diff basics/hello-world/.gitignore ${EXAMPLE_FOLDER}/.gitignore
so that this check can be removed?
This is ready for review
Should we copy the following files in the upgrade script:
Would that affect how the upgrade is script is run locally? For example would we need to set the EXAMPLE_FOLDER variable?
Maybe it's fine to keep them separate for now.
Closing as the structure evolved quite a lot