extension-examples icon indicating copy to clipboard operation
extension-examples copied to clipboard

Add check on CI to compare more files

Open jtpio opened this issue 4 years ago • 0 comments

Follow-up to https://github.com/jupyterlab/extension-examples/pull/119

Starting from JupyterLab 3.0 extensions can now be installed via pip, which is the way described in these examples.

New files have been added to each example, such as setup.py, MANIFEST.in and pyproject.toml:

https://github.com/jupyterlab/extension-examples/tree/ab5aefa454408b5cc6155c89eed8cc4db641c564/basics/hello-world

One way to check they are all in sync would be to run the upgrade script as mentioned in https://github.com/jupyterlab/extension-examples/pull/119#issuecomment-692118012

Similar to this step:

https://github.com/jupyterlab/extension-examples/blob/e7054af18aee9970f717fe5f015449c338098a2a/.github/workflows/main.yml#L45-L50

jtpio avatar Sep 15 '20 09:09 jtpio