extension-cookiecutter-ts icon indicating copy to clipboard operation
extension-cookiecutter-ts copied to clipboard

Should style/index.js import index.css instead of base.css ?

Open Carreau opened this issue 2 years ago • 3 comments

I have no clue, maybe I[m doing things wrong,] but any modif I do to index.css of an extension have no effect. It does if I apply them to base... that is unless I cahnge style/index.js to import from index and not base.

Carreau avatar Apr 11 '22 18:04 Carreau

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively. welcome You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

welcome[bot] avatar Apr 11 '22 18:04 welcome[bot]

The index.css/index.js mechanism comes from difficulties to tree shake styles in JupyterLab.

Long story short, the practice is to keep things as in this cookiecutter (aka index.css and index.js import base.css). And place your style in base.css.

fcollonval avatar Apr 12 '22 07:04 fcollonval

Ok, I'll see if I can make a pull request that explain this in index.css.

Carreau avatar Apr 12 '22 07:04 Carreau