jupyterlab-vim icon indicating copy to clipboard operation
jupyterlab-vim copied to clipboard

Rebind Esc to "Leave Current Mode"

Open asford opened this issue 2 years ago • 2 comments

This is an optional add-on to #69 that makes "Leave Current Mode" the default binding for Esc.

The leave-current-mode behavior of "Esc" could/should be made default for this plugin. Though this is a shift in behavior for existing jupyterlab-vim users, it's less disruptive for existing jupyterlab users.

Please finish the following when submitting a pull request:

  • [x] Add a line to History.md briefly documenting the change.

If this is a release, additionally do the following:

  • [x] Update the dependencies in package.json
  • [x] Run jlpm install to update yarn.lock

Thanks!

asford avatar Oct 01 '22 19:10 asford

Binder :point_left: Launch a binder notebook on branch asford/jupyterlab-vim/leave_current_mode_default

github-actions[bot] avatar Oct 01 '22 19:10 github-actions[bot]

I've uploaded a build to anaconda under jupterlab_vim=0.15.1+leave_current_mode, as I wasn't able to get the binding demo functioning particularly well.

asford avatar Oct 01 '22 20:10 asford

We will need to resolve conflicts here and possibly some more discussion. @ianhi do you have an opinion on this one?

krassowski avatar Mar 12 '23 23:03 krassowski

I think this is a very nice idea! It would also go a long way towards helping out with https://github.com/jupyterlab-contrib/jupyterlab-vim/issues/73

ianhi avatar Jun 16 '23 20:06 ianhi

@asford do you have time to resolve the merge conflicts - or would you prefer someone else resolve them and push?

ianhi avatar Jun 16 '23 20:06 ianhi

Please grab the conn on the merge. I'm no longer able to drive this PR.

asford avatar Jun 19 '23 23:06 asford

Not sure why this got autoclosed - and I seem unable to re-open it. very confusing.

ianhi avatar Aug 01 '23 17:08 ianhi

I wonder if inability to re-open the PR has something to do with deforking. It seems like the branch in the PR was forked from jwkvam's repo.

firai avatar Aug 03 '23 09:08 firai