jupyterlab-vim icon indicating copy to clipboard operation
jupyterlab-vim copied to clipboard

vim mode disabled for first cell when code cell extension is installed or for current cell when changing CodeMirror settings

Open firai opened this issue 1 year ago • 3 comments

Description

When a code cell extension, such as jupyterlab-execute-time, is installed alongside jupyterlab-vim, vim mode does not initialize in the first cell, and the user must switch to another cell and back in order to enable vim in the first cell.

Upon triage by @krassowski, changing CodeMirror settings for code cells also causes vim mode to be disabled for the current cell.

Reproduce

Type 1

  1. Install both jupyterlab-vim and jupyterlab-execute-time
  2. Create a new notebook

Type 2

  1. Install jupyterlab-vim alone
  2. Change CodeMirror settings

Expected behavior

vim mode properly initializes regardless of other extensions

Context

  • Extension versions: jupyterlab-vim 4.0.3 jupyterlab-execute-time 3.0.1
  • Operating System and its version: Windows
  • Browser and its version: Latest Firefox and Edge

firai avatar Oct 09 '23 08:10 firai

Would you mind opening an issue over in jupyterlab-execute-time?

krassowski avatar Oct 09 '23 09:10 krassowski

Investigated by @krassowski at https://github.com/deshaw/jupyterlab-execute-time/issues/97#issuecomment-1754064252. To be tracked here.

firai avatar Oct 10 '23 03:10 firai

Seems like this doesn't occur with every CodeMirror extension. When I use jupyterlab-vim with jupyterlab-indent-guides, neither first load nor changing settings for jupyterlab-indent-guides from the Settings Editor disables vim mode.

firai avatar Oct 17 '23 03:10 firai

It seems like the conflict with jupyterlab-execute-time has been fixed by https://github.com/deshaw/jupyterlab-execute-time/pull/120.

firai avatar Sep 08 '24 15:09 firai