jupyterlab-vim icon indicating copy to clipboard operation
jupyterlab-vim copied to clipboard

Please respect Jupyterlab settings for non-blinking cursor

Open gloryVine opened this issue 1 year ago • 6 comments

Hi. The blinking cursor in jupyterlab was an issue in the past, see e.g. here and here. This was ultimately resolved by providing the user with the ability to set cursorBlinkRate to zero. This also worked with jupyterlab-vim in the past. However, when I again started using it recently, I noticed that the cursor is now blinking again in all browsers, despite the above setting. Is there a way to make jupyterlab-vim respect the jupyterlab setting, or is there another way to disable cursor blinking?

gloryVine avatar Sep 07 '23 15:09 gloryVine

What version of jupyterlab-vim and Jupyterlab version are you using?

krassowski avatar Sep 07 '23 15:09 krassowski

Jupyterlab 4.0.5 and jupyterlab-vim 4.0.3 on macOS Ventura 13.4. Browsers tried were Firefox, Chromium and Safari.

gloryVine avatar Sep 07 '23 15:09 gloryVine

The extension was rewritten for JupyterLab 4.0, and depends on https://github.com/replit/codemirror-vim/. That however seems to hard-code the blinking rate. One would need to open an issue upstream to make it respect the current configuration of drawSelection extension from @codemirror/view.

Issue: https://github.com/replit/codemirror-vim/issues/140

krassowski avatar Sep 07 '23 15:09 krassowski

The fix/feature has been merged upstream. Now we just have to wait for a new release.

firai avatar Nov 08 '23 11:11 firai

@krassowski What's the right way to update the versions of @codemirror/view and @replit/codemirror-vim in the package? Should I just delete yarn.lock and let it re-populate, or should package.json and yarn.lock be edited manually to strictly control the versions of other packages?

firai avatar Nov 24 '23 06:11 firai

I would suggest to

  • make a PR bumping @codemirror/view in core jupyterlab (this would require bumping across package.json files especially in @jupyterlab/codemirror)
  • bump the required version of @replit/codemirror-vim, @codemirror/view and @jupyterlab/codemirror in package.json then run jlpm which will refresh the yarn.lock

krassowski avatar Nov 25 '23 12:11 krassowski