jupyterlab-topbar icon indicating copy to clipboard operation
jupyterlab-topbar copied to clipboard

Published 20 hours ago • verified publisher icon jupyterlab-contrib

Add support for other themes

Open jtpio opened this issue 11 months ago • 2 comments

Transferring https://github.com/jtpio/jupyterlab-theme-toggle/issues/3 here in this repo.

For now the theme toggle extension only support the dark and light themes:

https://github.com/jupyterlab-contrib/jupyterlab-topbar/blob/4eb59bc966d099f39d1aadad8bd47c63899b7d89/packages/theme-toggler-extension/src/index.tsx#L90-L93

However this could be made configurable via the settings system.

jtpio avatar Jul 26 '23 08:07 jtpio

How do you envision this? Changing to sort of dropdown component and letting users to configure more than two themes or still use toggler component where users can configure two themes at a given time?

mahendrapaipuri avatar Aug 03 '23 11:08 mahendrapaipuri

Since there is already the possibility to choose from a list of themes via the Settings menu, maybe limiting the toggle to 2 options would make sense?

End users would go to the settings editor to enter the names of the two themes they would like to use.

jtpio avatar Aug 03 '23 12:08 jtpio