jupyterlab-topbar icon indicating copy to clipboard operation
jupyterlab-topbar copied to clipboard

Add script to auto bump version in top level

Open mahendrapaipuri opened this issue 10 months ago • 2 comments

  • The script ensures that version in top level package.json would be consistent with packages

  • Run this script after bump version step in jupyter-releaser

@jtpio Do you think a simple script like this would be enough for stream lining releases?

mahendrapaipuri avatar Apr 06 '24 16:04 mahendrapaipuri

Thanks @mahendrapaipuri for looking into this.

Yes it should be fine for now if we always bump all the packages together during a release. Maybe we can later investigate how the packages could be versioned independently.

jtpio avatar Apr 08 '24 13:04 jtpio

What do you think about following workflow for independent versionining:

  • We skip bump-version step of jupyter-releaser
  • We bump versions of few or all packages manually with a separate PR. Versions can be different for different packages
  • The current custom script will bump the version of top level package.json automatically. The tag will be created in the repo based on this version and so we should choose a versioning strategy that is meaningful.
  • In the prep-release workflow, we create an additional input like packages and we will pass the packages that have been bumped from this input. We pass this information to jupyter-releaser using env var RH_PYTHON_PACKAGES.

This will still build npm artifacts for all packages and attempt to publish them. I am not sure if npm registry throws an error if we are attempting to publish the same version of the package or ignores it.

mahendrapaipuri avatar Apr 08 '24 13:04 mahendrapaipuri