jlab-enhanced-launcher icon indicating copy to clipboard operation
jlab-enhanced-launcher copied to clipboard

Published 20 hours ago • verified publisher icon jupyterlab-contrib

list view: icons too large

Open nick-youngblut opened this issue 2 years ago • 3 comments

When I click on list view, many of the icons on the start of each list entry are too large:

Screen Shot 2022-09-19 at 5 13 18 PM

JupyterLab Version 3.4.7

MacOS v12.5.1, MacBook Pro (13-inch, M1, 2020)

nick-youngblut avatar Sep 20 '22 00:09 nick-youngblut

Thanks for reporting @nick-youngblut

Would you be willing to open a PR to fix that? I can provide pointers.

fcollonval avatar Sep 20 '22 06:09 fcollonval

Sure, but I'd need a lot of pointers. I don't even now where to begin

nick-youngblut avatar Sep 20 '22 15:09 nick-youngblut

The good way is

  1. to open the development tools in your browser
  2. to select the element, you want to edit
  3. to add new CSS rule

See example in the below screencast - it demonstrate how to set the background-color of an icon.

test-style

You may need to search the web for your specific trouble as I cannot reproduce it (on Firefox on Windows).

Once you know what CSS rule needs to be set. You can open a PR modifying https://github.com/jupyterlab-contrib/jlab-enhanced-launcher/blob/master/style/table.css to add that new rule.

Don't hesitate to open the PR early even if it does not work so I can provide help.

fcollonval avatar Sep 22 '22 11:09 fcollonval