zero-to-jupyterhub-k8s icon indicating copy to clipboard operation
zero-to-jupyterhub-k8s copied to clipboard

Published 20 hours ago • verified publisher icon jupyterhub

Added ability to specify labels for k8s-objects like DaemonSets and Deployments

Open nlcti opened this issue 2 years ago • 1 comments
trafficstars

Hi, I was requested by a client to label all k8s objects of the Jupyterhub helm chart with additional, team specific informations.

Therefore I added a helper function called jupyterhub.determinedLabels to the _helpers.tpl, which extracts given labels from the values.yaml and appends them to the commonLabels.

As far as I see it, this solution overlaps with the pull request https://github.com/jupyterhub/zero-to-jupyterhub-k8s/pull/2948 . As it reaches out not only for the Deployment-objects, but everything which gets labeled via commonLabels, I suppose it is more generic.

nlcti avatar Dec 13 '22 16:12 nlcti

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly. welcome You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

welcome[bot] avatar Dec 13 '22 16:12 welcome[bot]