zero-to-jupyterhub-k8s
zero-to-jupyterhub-k8s copied to clipboard
jupyterhub
Existing PVCs keep old chart labels after upgrade
Bug description
When you upgrade your jupyterhub installation to a new helm chart via "helm upgrade" command, the labels of existing PVCs are not accordingly changed.
E.g., suppose you first install version 1.1.4. On the first login of a new user, a new PVC with label "chart: jupyterhub-1.1.3" will be created. If you then upgrade to version 1.2.0, the existing PVC will keep its label. However, any subsequently initialized PVCs will have the label "chart: jupyterhub-1.2.0".
Expected behaviour
Existing PVCs should be relabeled if necessary. Alternatively, if the current behavior is actually a feature, the documentation should say so explicitly.
The PVCs for users are not managed by the Helm chart, but by KubeSpawner. For KubeSpawner to start checking and modifying the labels on the PVCs would be a quite significant addition of complexity.
I consider this something we won't fix, and I think it's also documented in some places that changing details on the KubeSpawner created resources is only influencing them during creation.
