wrapspawner icon indicating copy to clipboard operation
wrapspawner copied to clipboard

Published 20 hours ago • verified publisher icon jupyterhub

Use progress from child spawner

Open akhilputhiry opened this issue 6 years ago • 3 comments

See https://github.com/jupyterhub/kubespawner/issues/272 for details

akhilputhiry avatar Oct 22 '18 20:10 akhilputhiry

@minrk Let me know your thoughts

akhilputhiry avatar Oct 22 '18 20:10 akhilputhiry

Note: duplicate of #21.

This method would require Python 3.5, and then we'll have to update batchspawner requirements to 3.5 in most cases. I don't mind and it would solve some other problems, but others would rather us support 3.4 longer.

rkdarst avatar Oct 22 '18 20:10 rkdarst

Now batchspawner doesn't support python3.4, but should this require 3.5 too? That seems to be the main choice between this and #21.

This could be modified to handle the case of no child spawner yet (probably rare but perhaps useful), and then to directly return the child spawner method instead of running through a new generator. But that's basically #21...

rkdarst avatar Jun 18 '19 21:06 rkdarst