the-littlest-jupyterhub icon indicating copy to clipboard operation
the-littlest-jupyterhub copied to clipboard

Update nbgitpuller URL

Open rdmolony opened this issue 3 years ago • 1 comments

Previous URL is broken

  • [x] Add / update documentation
  • [ ] Add tests

rdmolony avatar Aug 08 '22 14:08 rdmolony

Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly. welcome You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:

welcome[bot] avatar Aug 08 '22 14:08 welcome[bot]

Thank you @rdmolony for noticing this! This was the tip of the iceberg as the whole section was outdated. I went ahead and revised it and updated the title to reflect it.

@GeorgianaElena @manics, what do you think?

consideRatio avatar Sep 09 '22 19:09 consideRatio

Looks good to me! Makes sense to link out to the NBGitPuller docs instead of duplicating documentation.

https://nbgitpuller.link isn't working at the moment though 😢, do you know how long it's been broken for?

manics avatar Sep 14 '22 17:09 manics

@manics ah, I think it worked when i wrote the previous commits. I don't know about whats happened to the domain and its pointing to the github pages page: https://jupyterhub.github.io/nbgitpuller/link.html, but let's stop using it.

consideRatio avatar Sep 14 '22 17:09 consideRatio

Congrats on your first merged pull request in this project! :tada: congrats Thank you for contributing, we are very proud of you! :heart:

welcome[bot] avatar Sep 14 '22 17:09 welcome[bot]