repo2docker icon indicating copy to clipboard operation
repo2docker copied to clipboard

[MRG] Update to JupyterLab 4

Open jtpio opened this issue 1 year ago • 1 comments
trafficstars

Extract the part of https://github.com/jupyterhub/repo2docker/pull/1302 to update to JupyterLab 4, without the Notebook 7 update.

jtpio avatar Mar 28 '24 16:03 jtpio

jupyter-server version to 2.x (how much of a breaking change is this?)

The default CMD still launches the old server via jupyter notebook it seems though?

https://github.com/jupyterhub/repo2docker/blob/f667caf49c9f199304b210b6643771b4c7a08053/repo2docker/buildpacks/base.py#L194

Support for python 3.7 in the base environment is now gone. How does this affect repos that specify python 3.7?

Python 3.7 reached end of life in June 2023: https://github.com/jupyterlab/jupyterlab/pull/13745. JupyterLab 4 requires Python 3.8 now.

jupyterlab to 4.x (so some extensions would break)

Yes, although many have been updated now: https://github.com/jupyterlab/jupyterlab/issues/14590

Also JupyterLab 3 will reach end of maintenance soon: https://github.com/jupyterlab/jupyterlab/issues/15921

jtpio avatar Mar 29 '24 06:03 jtpio

How does this affect repos that specify python 3.7?

They are unaffected at the moment. As this PR stands, 3.7 stops getting updates, but continues to be supported for the server environment.

The next stage of reduced support is bumping kernel_env_cutoff_version to 3.8, at which point 3.7 becomes a 'kernel-only' version, like 3.6 and older. I think would be reasonable to make this change here as well, but not required.

Pro bumping kernel_env_cutoff:

  • all installs get the same jupyterlab/server versions
  • we will need to make this transition eventually, when e.g. a security requirement requires bumping a no-longer-supported package

Con:

  • bigger, more disruptive change for 3.7-using repos

Since there is no visible effect on 3.7 repos, I think it's fine to merge this as-is.

minrk avatar May 21 '24 08:05 minrk

This may break users who are installing extensions which aren't compatible with JupyterLab 3. I think we should make an announcement on https://discourse.jupyter.org before merging.

manics avatar May 21 '24 08:05 manics

announced: https://discourse.jupyter.org/t/ann-repo2docker-upgrading-to-jupyterlab-4/25845

minrk avatar May 22 '24 07:05 minrk

Thanks @jtpio and @minrk :)

yuvipanda avatar May 29 '24 20:05 yuvipanda