repo2docker
repo2docker copied to clipboard
jupyterhub
Add ARM64 support to repo2docker
I got a M1 Mac, what else does one do to procrastinate?
Fixes #1120
TODO:
- [ ] Have frozen versions of the conda-lock files be architecture specific
- [ ] Be platform specific in getting R
- [ ] Setup arm tests for everything
I see:
Warning: repo2docker:app.py:814 ---> [Warning] The requested image's platform (linux/arm64/v8) does not match the detected host platform (linux/amd64) and no specific platform was requested
everywhere, and am not sure if qemu is actually even being used? We don't use buildx, as we talk to it via the docker API (not buildx). Is it actually not possible to do this via the API? All the docs I can find seem to suggest using buildx
Looks like docker-py doesn't support buildx https://github.com/docker/docker-py/issues/2230
everywhere, and am not sure if qemu is actually even being used?
If the build steps don't fail immediately, qemu's involved. You'll get some kind of exec error if there's no qemu. It is weird that it thinks no platform is requested, though.
@minrk they currently fail with:
2022-08-26T10:38:55.0109683Z INFO repo2docker:app.py:814 [91m/tmp/install-base-env.bash: /srv/conda/envs/kernel/bin/ipython: /srv/conda/envs/kernel/bin/python: bad interpreter: No such file or directory
which I'd assume means they aren't using QEMU, and that's the arm binary trying to get started in an amd64 context.
It works on my local machine tho
Given how long our tests take, it may make sense to run arm tests on circle. I just did this on pyzmq, and it was ~10x faster than qemu on GHA.
Presumably we only need a pretty basic couple of tests, though.
I dunno when I'll be able to work on this again though, would love for someone else to take it over <3
A tarot card reader on the streets of los angeles told me that completion of this PR is not something she sees in my future given that Saturn is in retrograde, and I will hence close this in favor of the amazing #1228