oauthenticator icon indicating copy to clipboard operation
oauthenticator copied to clipboard

feat: Implement `oauthenticator.OAuthenticator.refresh_user` method

Open Wykiki opened this issue 2 years ago • 9 comments
trafficstars

This MR aims to implement the refresh_user()'s Authenticator method in OAuthenticator class.

Following #398 comment.

At the time of writing, nothing has been tested, and provider specific code would be needed, as the OAuth2 spec does not force the expires_in field in the access_token response body.

I may not have bandwidth soon to work again on this, feel free to take the lead !

Wykiki avatar Mar 28 '23 09:03 Wykiki

I'll be super excited to try get this to eventually land :)

yuvipanda avatar Oct 05 '23 06:10 yuvipanda

@yuvipanda I don't have bandwidth to work on it anymore, so feel free to take over the code !

Wykiki avatar Oct 05 '23 06:10 Wykiki

@Wykiki I'll poke around and try to find someone!

yuvipanda avatar Oct 05 '23 06:10 yuvipanda

And thank you for your contribution :)

yuvipanda avatar Oct 05 '23 06:10 yuvipanda

Hello! Was any progress made here? This would be useful for my work, and this looks like a fairly complete implementation (thanks!).

epstein6 avatar Nov 30 '23 16:11 epstein6

I've been using this with gitlab with a couple of compatibility changes (adding the redirect_url and the client info) and it seems to work. Are there any other particular changes that would need to be done here for this to be merged?

epstein6 avatar Apr 04 '24 18:04 epstein6