oauthenticator icon indicating copy to clipboard operation
oauthenticator copied to clipboard

[AzureAD] app roles for something similar to admin_groups and allowed_groups

Open weisdd opened this issue 2 years ago • 4 comments

Proposed change

Currently, AzureAD has a very basic implementation, which doesn't allow to work with users based on their group membership for admin access or for prohibiting from entering JupyterHub.

IMO, app roles would be the simplest implementation. They can be added to a group (a user must be a direct member of the group), so we would see those roles in an ID token and can later decide whether a user can be considered an admin or prohibited from entering JupyterHub at all. We could see something similar (only for role mapping) in Grafana's AzureAD integration.

Alternative options

Based on what I learned about AzureAD in a couple of days (hadn't really worked with it before), linking anything to groups will require us to give additional privileges to an app and to send subsequent requests to another endpoint, which seems to be too complex.

Who would use this feature?

Anyone who relies on Azure AD.

(Optional): Suggest a solution

I'll open a PR with a draft implementation.

weisdd avatar Jul 15 '21 18:07 weisdd

any updates on this? I'd really like to be able to use this feature.

Bfoster-melrok avatar Aug 18 '21 18:08 Bfoster-melrok

@Bfoster-melrok PR still stays without any comments from JupyterHub maintainers, so no further progress.

weisdd avatar Aug 18 '21 20:08 weisdd

Hi from 2022 :) any plans to implement the requested feature ?

malaman avatar Aug 02 '22 06:08 malaman

Hi from 2023 :)

I would also like to know if there are any plans to implement this, or if there is a workaround to get the same functuionality?

christian-sapconet avatar Sep 07 '23 09:09 christian-sapconet