oauthenticator
oauthenticator copied to clipboard
[Generic] Add support for client_secret_post method
Support the client_secret_post method as specificed at https://openid.net/specs/openid-connect-core-1_0.html#ClientAuthentication
Keeps the behaviour of the basic_auth
config and adds a new config parameter client_auth_method
to support client_secret_post
and client_secret_basic
(this is the currently existing one)
Thanks for submitting your first pull request! You are awesome! :hugs:
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! :wave:
Welcome to the Jupyter community! :tada:
This is very similar to #274
Thank you very much for this work @enolfc! This and the discussion in the meta issue has been really helpful in finding and fixing this bug ✨
I will close this PR now that the bug has been fixed as part of https://github.com/jupyterhub/oauthenticator/pull/568 and this refactor https://github.com/jupyterhub/oauthenticator/pull/526