nbgitpuller icon indicating copy to clipboard operation
nbgitpuller copied to clipboard
verified publisher icon jupyterhub

Support building on mybinder.org to ease testing

Open manics opened this issue 3 years ago • 2 comments

At the moment if you want to test a PR that affects the UI you need to clone the PR and install it locally. In many cases testing on mybinder.org is good enough, the main exceptions are some interactions which are dependent on whether jupyter-notebook or jupyter-server is used.

manics avatar Mar 17 '22 23:03 manics

Can you make it a .binder folder, and add an inline comment in the requirements.txt file that this is to help us start the repo at mybinder.org for UI testing purposes?

consideRatio avatar Mar 18 '22 09:03 consideRatio

I implemented the changes I suggested and force pushed a rebase. Instead of binder/requirements, its not .binder/requirements.txt with an inline comment about its purpose.

@manics wdyt about this PR as it is now?

I noted that I could get nbgitpuller started without having .binder/requirements.txt, which made sense to me as i believe repo2docker will detect setup.py etc and install this directly.

consideRatio avatar Aug 01 '23 07:08 consideRatio