mybinder.org-deploy icon indicating copy to clipboard operation
mybinder.org-deploy copied to clipboard

Serve mybinder bagdes from static.mybinder.org

Open yuvipanda opened this issue 6 years ago • 5 comments

Serving badges from mybinder.org runs into privacy and cookie problems, which caused us to set up static.mybinder.org. Currently, we're again serving badges from mybinder.org - we should be serving them from static.mybinder.org instead.

https://github.com/jupyterhub/binderhub/issues/379 for previous time this happened.

yuvipanda avatar Jan 04 '19 01:01 yuvipanda

static.mybinder.org/badge.svg also doesn't seem to be working anymore?

Edit: Ah, nvm, it is.

yuvipanda avatar Jan 04 '19 01:01 yuvipanda

Apparently I misremembered - we were always sending them from mybinder.org - static was a place for other projects (specifically, sphinx gallery) to be able to load from. They can load badge_logo.svg too now.

https://github.com/jupyterhub/binderhub/issues/392 for making this configurable.

yuvipanda avatar Jan 04 '19 01:01 yuvipanda

We need to update the code for https://mybinder.org/ as well

betatim avatar Jan 04 '19 06:01 betatim

hmmm, do we have this documented somewhere? I'm a bit worried that @yuvipanda had to figure out what one of our subdomains was for :-) (I definitely would have had this problem as well)

choldgraf avatar Jan 04 '19 14:01 choldgraf

@choldgraf you filed #822 last time ;)

yuvipanda avatar Jan 04 '19 19:01 yuvipanda